Admin Events Convention#

Events are a great way for back end systems and user interfaces to stay up to date with the latest governance changes. They also serve as audit logs for the contract.

In Governor.sol, when a change is made to a governance parameter, an event is emitted, e.g. VotingPeriodSet and ProposalThresholdSet.

PVFDGovernance, however, breaks this convention and does not emit events when governance parameters around quorum are modified.

Recommendation#

Declare and emit BaseSupplySet(uint16 count) and QuorumBipsSet(uint16 bips) events when modifying governance quorum parameters to inform any systems listening for events.