Compound governance quorum is determined by the following condition:
proposal.forVotes < quorumVotes
quorumVotes is an immutable constant.
By contrast, PVFD fork quorum is determined by
proposal.quorum is determined at proposal time as a function of token supply and quorum bips set by meta-governance.
The break from Compound convention of quorum being solely determined by
forVotes is worth documenting at the
state function level as well as in communications to users. End users might have expectations around what determines quorum that differ from this implementation.
It is also worth noting that governance UIs such as Tally expect a
quorumVotes constant for their quorum display.
- Document the unique quorum calculation in the
statefunction in natspec format
- If perfect compatibility with governance UIs is desired, there may need to be more substantial revision to the quorum mechanic.